Chat Logs

  1. * phaleth joined #primate
  2. * skillbot joined #primate
  3. * skillnews joined #primate
  4. phalethsolidjs is doing some breaking changes https://github.com/solidjs/solid/blob/next/documentation/solid-2.0/MIGRATION.md
  5. * phaleth joined #primate
  6. bluephaleth: wow
  7. bluephaleth: https://repopack.com/project/primate/tasks/80#message-3046
  8. nevetRepopack 路 Sign in
  9. bluedid you configure the app to have another bundle for docs?
  10. bluealso I'll look look at the size increase
  11. phalethnope, another entrypoint has to be configured for each route?
  12. phalethlooks the size of @primate/core has been incresing, but it's not too bad given the trouble with SSE
  13. blueyes, phaleth; see https://repopack.com/project/primate/tasks/80#apps%2Fwebsite%2Fviews%2Fdocs%2Fdocs%2Fconfiguration.md
  14. nevetRepopack 路 Sign in
  15. phalethdoes that mean for primate website we have to define `groups: { docs: "/docs", guides: "/guides", blog: "/blog" }` and only then those routes will be split?
  16. blueyes; note that the splitting as it is currently will create full (not shared) bundles for all three. so browsing between those fences will load those full bundles instead of reusing share code. If we need a shared code functionality, then we need to extend this feature
  17. phalethah, ok, sounds good
  18. bluesonuds good as in, we need shared bundles, or you're ok with how it is? probably for primate website shared common code is better for perf
  19. phalethit depends on how big is the "core" of the primate website app
  20. blueI'll have clanker analyse.
  21. * blue clankering
  22. phalethor in other words if the chunk being split out is 40 kB of JS or more then it's worth splitting the route
  23. bluehm, that's hard to know in advance
  24. phalethyes, has to be tested on primate website, I think this scenario is ideal `groups: { app: "/", docs: "/docs", guides: "/guides"}`
  25. phalethif the homepage app JS bundle size drops significantly then the implementation is good
  26. bluegood goal definition
  27. bluephaleth: please check out primate#80 (you should get a bell)
  28. phalethalright
  29. bluethe last note is a bit clankered I feel "This would be a separate follow-up capability rather than an implicit change to #80's isolation contract.". I would implement everything as part of #80
  30. blueI wonder this feature done right in one go, not different tasks
  31. blueI want*
  32. phalethyeah, I can see what you are trying to do there
  33. phalethbut it's getting a bit hairy
  34. blueyou have a better direction?
  35. blueclanker came up with some overengineered conf object, I told him to simplify it
  36. phalethyeah, checking the route prefixes is fine, no need for other operations
  37. phalethI will just try it on primate website
  38. bluewell, the graphs thing is good to avoid having full bundles
  39. blueotherwise /, /docs and /guides will all be very big, you gain nothing
  40. bluegoal is for / to be small I think
  41. phalethyeah, I'm reading
  42. phalethtypescript is getting in the way, but that's because primate still uses pnpm which kinda ignores TS errors it seems
  43. blueyes
  44. phalethmind if I just fixed all those errors so we can get replace pnpm to make the development faster?
  45. bluesure
  46. phalethok, let me comment, I think it's not going well
  47. bluek
  48. phalethdone :)
  49. phalethlooks like for primate website itself current changes are not a big deal as the core of the JS bundle is just too big
  50. phalethbut if those changes are good for repopack after the bug I found is fixed then I think it's all good
  51. phalethshould I also respond to the `graphs` idea?
  52. blueyes
  53. phalethalright
  54. phalethclanker is always so confident :)
  55. phalethanyway, this change prolly won't do much for primate website even with the graphs feature, but worth a shot I guess
  56. blueya
  57. phalethalso it seems like the graphs feature won't be flawless, may as well abandon the idea
  58. bluewhy not? also dev clanker finished, review clanker is now checking
  59. blue(finished fix, I mean)
  60. bluebtw if you have issues with graphs feature, please post in tank
  61. bluetask*
  62. bluephaleth: pinged you
  63. phalethit just looks to me the rabbit hole got too deep, but I can test
  64. bluewe're not doing graphs yet, the fix was for the error you encountered
  65. blueok phaleth, looks now like it's working for you, yes?
  66. blueby the way, what do you mean with "full load"? it's supposed to load the additional assets
  67. phalethI will comment what I mean by full load
  68. bluek
  69. phalethok, commented
  70. bluegreat, I see you also asked for changes, so it's now in REVISION
  71. bluegreat
  72. phalethheh
  73. * phaleth joined #primate
  74. * phaleth joined #primate
  75. * nevet joined #primate
  76. * blue!~blue@user/blue changed the topic to: https://primate.run | this channel is mirrored to the Primate discord, channel #irc
  77. * phaleth joined #primate
  78. * jreicher joined #primate
  79. * skillbot joined #primate
  80. * skillnews joined #primate